Updating datastore to use v1 #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| // The version of the entity that this mutation is being applied to. If this | ||
| // does not match the current version on the server, the mutation conflicts. | ||
| int64 base_version = 8; | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM. Should we open issues for the two new features in the |
| // For [missing][google.datastore.v1.LookupResponse.missing] entities in `LookupResponse`, this | ||
| // is the version of the snapshot that was used to look up the entity, and it | ||
| // is always set except for eventually consistent reads. | ||
| int64 version = 4; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
#2112 tracks the new versioning / conflict detection feature of the V1 API. |
|
Jinx. D'oh. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2105
Used
Makefile.datastore(after updating it) to re-generate the generated modules