-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kill off 'DEFAULT_TOPIC_NAME'. #2195
Kill off 'DEFAULT_TOPIC_NAME'. #2195
Conversation
@dhermes, @daspecster I'm tempted to kill off the Travis for the PR and merge immediately: the system tests pass with this change on my box, and |
The resource ID has per-second granularity on Travis. You probably want to go lower by a factor of 100. Add an optional argument to multiply seconds in |
@tseaver I urge you to resist the temptation. Travis won't run your job for hours so it's not worth subverting the review process |
I just read the definition of "subvert". A very dramatic word |
We're already mangling in the
That means it will be double that number of hours before we know whether it works. |
Sorry I didn't realize your prefixes were unique, so it's moot. LGTM to merge (no need to wait on Travis if you've run all the tox environmentsvthst Travis will) |
*environments that (typing on phone, sorry) |
The hypothesis is that we are seeing flakiness due to rapid creation / deletion cycles on topics with the shared name.
Towards #2163, #2192.