Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix README installation command and PyPI links #2264

Merged
merged 4 commits into from
Sep 13, 2016
Merged

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Sep 8, 2016

The current PyPI install command, links, and images point to the wrong package. I suppose this might be due to the new auto-generated documentation platform in use.

it currently doesn't work
current PyPI install command, links, and images point to the wrong
package
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 8, 2016
@ofek
Copy link
Contributor Author

ofek commented Sep 8, 2016

I've just signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 8, 2016
@dhermes
Copy link
Contributor

dhermes commented Sep 8, 2016

Thanks for the PR but the change was intended. We are moving to google-cloud. See #1978 for context

@ofek
Copy link
Contributor Author

ofek commented Sep 8, 2016

@dhermes Ah, I see. Shouldn't we wait to update install command/links since, as of now, they are incorrect? This may confuse the product's users, especially the error-producing pip install google-cloud.

@dhermes
Copy link
Contributor

dhermes commented Sep 8, 2016

Hopefully it will be transient, i.e. hopefully we have new versions ASAP

@tseaver
Copy link
Contributor

tseaver commented Sep 8, 2016

We do need to publish a new version of the package Real Soon Now(TM). Likely a 0.19.0 version for the monolithic package, before we start pushing out releases for the API-specific sub-packages.

dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Sep 8, 2016
This is the first release after the rename.

Closes googleapis#2264.
@dhermes dhermes mentioned this pull request Sep 8, 2016
@daspecster daspecster added the docs label Sep 8, 2016
@tseaver
Copy link
Contributor

tseaver commented Sep 9, 2016

@Ofekmeister Thanks for the patch~ I am closing the PR without merging., because as soon as we can get a release out, the links as they stand now (without your patch) will be correct.

@tseaver tseaver closed this Sep 9, 2016
@daspecster
Copy link
Contributor

@tseaver, I'm reopening from #2298

@daspecster daspecster reopened this Sep 13, 2016
@@ -41,7 +41,7 @@ Quick Start

::

$ pip install --upgrade google-cloud
$ pip install -U gcloud

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Sep 13, 2016

@Ofekmeister This looks mostly fine other than my comment about leaving --upgrade alone (instead of replacing it with -U). Also, this change is tiny, so can you squash into one commit?

$ git checkout master  # that is the name of your branch sent in this PR
$ git branch -m master master-old  # Renames the local master branch
$ git fetch upstream  # Make sure up to date
$ git branch master upstream/master  # Adds a tracking branch for the project's master
$ git checkout master
$ git merge --squash master-old
$ git diff origin/master  # Make sure the changes aren't too crazy.
$ git push --force origin master  # This will overwrite the extra commits in this PR

@tseaver
Copy link
Contributor

tseaver commented Sep 13, 2016

@dhermes For a change this tiny, we could just squash merge it in the Github UI: I don't think we care about exposing it in a changelog.

@dhermes
Copy link
Contributor

dhermes commented Sep 13, 2016

@tseaver Good call.

@ofek
Copy link
Contributor Author

ofek commented Sep 13, 2016

I believe I'm failing with git today. Can I just close this and open a new PR with all changes in one commit?

edit: git checkout master threw error: pathspec 'master' did not match any file(s) known to git.

@dhermes
Copy link
Contributor

dhermes commented Sep 13, 2016

@Ofekmeister no worries, we can just use the GitHub squash merge feature on the PR. If you'd like to hone your git skills I'm happy to help you sort it out via Hangouts chat.

@ofek
Copy link
Contributor Author

ofek commented Sep 13, 2016

Yes, if you guys could please squash on your end that would be great.

@dhermes Thanks for the offer! That would be enlightening :) Based on search results, I believe it is a Windows issue.

@tseaver
Copy link
Contributor

tseaver commented Sep 13, 2016

I cancelled the Travis build, as this PR only affects the README.

@tseaver tseaver merged commit 3a831ee into googleapis:master Sep 13, 2016
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Sep 19, 2016
This is the first release after the rename.

Closes googleapis#2264.
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Sep 19, 2016
This is the first release after the rename.

Closes googleapis#2264.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants