-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'QueryJob.results' method #2321
Add 'QueryJob.results' method #2321
Conversation
Construct the instance using the job's properties, and bind it to the job.
Constructs a 'QueryResults' instance, bound to the job. Closes #2083.
Should there be something in the bigquery-usage doc about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I'll let someone more familiar with google-cloud-python approve.
@@ -172,3 +172,55 @@ def _validate(self, value): | |||
""" | |||
if value not in self.ALLOWED: | |||
raise ValueError('Pass one of: %s' ', '.join(self.ALLOWED)) | |||
|
|||
|
|||
class UDFResource(object): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -65,6 +65,26 @@ def __init__(self, query, client, udf_resources=()): | |||
self.udf_resources = udf_resources | |||
self._job = None | |||
|
|||
@classmethod | |||
def from_query_job(cls, job): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending Travis
|
||
class UDFResource(object): | ||
"""Describe a single user-defined function (UDF) resource. | ||
:type udf_type: str |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Closes #2083.
/cc @jonparrott, @tswast