Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'QueryJob.results' method #2321

Merged
merged 5 commits into from
Sep 15, 2016
Merged

Add 'QueryJob.results' method #2321

merged 5 commits into from
Sep 15, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 15, 2016

Closes #2083.

/cc @jonparrott, @tswast

Construct the instance using the job's properties, and bind it to the job.
Constructs a 'QueryResults' instance, bound to the job.

Closes #2083.
@tseaver tseaver added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: bigquery Issues related to the BigQuery API. labels Sep 15, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2016
@daspecster
Copy link
Contributor

Should there be something in the bigquery-usage doc about this?

Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'll let someone more familiar with google-cloud-python approve.

@@ -172,3 +172,55 @@ def _validate(self, value):
"""
if value not in self.ALLOWED:
raise ValueError('Pass one of: %s' ', '.join(self.ALLOWED))


class UDFResource(object):

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@@ -65,6 +65,26 @@ def __init__(self, query, client, udf_resources=()):
self.udf_resources = udf_resources
self._job = None

@classmethod
def from_query_job(cls, job):

This comment was marked as spam.

Copy link
Contributor

@daspecster daspecster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Travis

@tseaver tseaver merged commit a92d69f into googleapis:master Sep 15, 2016
@tseaver tseaver deleted the 2083-bigquery-async_query_job-query_results branch September 15, 2016 20:02

class UDFResource(object):
"""Describe a single user-defined function (UDF) resource.
:type udf_type: str

This comment was marked as spam.

@tseaver tseaver mentioned this pull request Sep 16, 2016
@dhermes dhermes mentioned this pull request Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants