Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging/pubub system tests #2260

Merged
merged 1 commit into from
Sep 7, 2016
Merged

Fix logging/pubub system tests #2260

merged 1 commit into from
Sep 7, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 7, 2016

Broken after #2223.

  • Namespace packages break use of 'Client' from package.
  • Shorten bucket / topic names to match limits.
  • Stop sharing sink / metric names across tests (brush clearing to find the real issue with bucket / topic names).

@tseaver
Fix logging/pubub system tests after #2223.
1390fbd 
- Namespace packages break use of 'Client' from package.

- Shorten bucket / topic names to match limits.

- Stop sharing sink / metric names across tests.
@tseaver tseaver added testing api: pubsub Issues related to the Pub/Sub API. api: logging Issues related to the Cloud Logging API. labels Sep 7, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2016
@daspecster
Copy link
Contributor

LGTM pending travis!

@tseaver tseaver mentioned this pull request Sep 7, 2016
Closed
@tseaver
Copy link
Contributor Author

tseaver commented Sep 7, 2016

Travis will pass for the PR (only changes to system_tests/), but fail on merge (due to other #2259 issues).

@tseaver tseaver merged commit 2499735 into googleapis:master Sep 7, 2016
@tseaver tseaver deleted the pubsub-logging-post-2223-system-tests branch September 7, 2016 18:38
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @daspecster @dhermes @googlebot