Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #171: rework query clone to avoid spurious copy of dataset #254

Merged
merged 3 commits into from
Oct 17, 2014
Merged

Fix #171: rework query clone to avoid spurious copy of dataset #254

merged 3 commits into from
Oct 17, 2014

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 17, 2014

Fixes #171.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 137bfe2 on tseaver:171-rework_query_clone_deepcopy into 906700b on GoogleCloudPlatform:master.

@tseaver tseaver mentioned this pull request Oct 17, 2014
Merged
dhermes
dhermes reviewed Oct 17, 2014
View reviewed changes
gcloud/datastore/query.py
@@ -67,8 +67,9 @@ def _clone(self):
:rtype: :class:`gcloud.datastore.query.Query`
:returns: a copy of 'self'.
"""
clone = copy.deepcopy(self)

This comment was marked as spam.

Sign in to view

@tseaver
Unused import.
7eae97f 
Incorporate feedback from @dhermes.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7eae97f on tseaver:171-rework_query_clone_deepcopy into 906700b on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor

dhermes commented Oct 17, 2014

LGTM

It appears a comment I made never posted. I was confirming that kind would be set on clone just as it was in the constructor. It appears it should since after being initialized, the kind from the constructor would live on the pb.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 17, 2014

Your comment is correct: the 'kind' is carried on the 'pb.

tseaver added a commit that referenced this pull request Oct 17, 2014
@tseaver
Merge pull request #254 from tseaver/171-rework_query_clone_deepcopy
83e8262 
Fix #171: rework query clone to avoid spurious copy of dataset
@tseaver tseaver merged commit 83e8262 into googleapis:master Oct 17, 2014
@tseaver tseaver deleted the 171-rework_query_clone_deepcopy branch October 17, 2014 20:00
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
parthea pushed a commit that referenced this pull request Jun 4, 2023
@release-please
chore(main): release 1.9.0 (#254)
a2ee510 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): add support for python 3.11 [autoapprove] (#254)
7bcb79f 
Source-Link: https://github.com/googleapis/synthtool/commit/7197a001ffb6d8ce7b0b9b11c280f0c536c1033a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320
parthea pushed a commit that referenced this pull request Jun 4, 2023
@release-please
chore(main): release 1.4.5 (#254)
9af9432 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
build(deps): bump requests to 2.31.0 [autoapprove] (#254)
d521224 
Source-Link: https://github.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
parthea pushed a commit that referenced this pull request Jun 4, 2023
@release-please
chore(main): release 1.7.1 (#254)
cf62076 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore: regenerate API index (#254)
de967f5 
* chore: regenerate API index

Source-Link: googleapis/googleapis@40a03de

Source-Link: googleapis/googleapis-gen@6c17328
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmMxNzMyOGU5ZTFjMmI1OGU5NjAwNzIyZThmYzhjYmU4NDYwMGQ3ZiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): add support for python 3.11 [autoapprove] (#254)
60c8def 
Source-Link: https://github.com/googleapis/synthtool/commit/7197a001ffb6d8ce7b0b9b11c280f0c536c1033a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-media-translation to v0.1…
50e551f 
…1.0 (#254)
parthea added a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot @parthea
chore: use gapic-generator-python 0.58.4 (#254)
1093e27 
* chore: use gapic-generator-python 0.58.4

fix: provide appropriate mock values for message body fields

committer: dovs
PiperOrigin-RevId: 419025932

Source-Link: googleapis/googleapis@73da669

Source-Link: googleapis/googleapis-gen@46df624
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
feat: Add support for python 3.11 (#254)
6e0bc90 
* feat: Add support for python 3.11

chore: Update gapic-generator-python to v1.8.0
PiperOrigin-RevId: 500768693

Source-Link: googleapis/googleapis@190b612

Source-Link: googleapis/googleapis-gen@7bf29a4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
fix(deps): require google-api-core>=1.32.0,>=2.8.0 (#254)
c6e4f94 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 459095142

Source-Link: googleapis/googleapis@4f1be99

Source-Link: googleapis/googleapis-gen@ae686d9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWU2ODZkOWNkZTRmYzNlMzZkMGFjMDJlZmI4NjQzYjE1ODkwYzFlZCJ9


feat: add audience parameter
PiperOrigin-RevId: 456827138

Source-Link: googleapis/googleapis@23f1a15

Source-Link: googleapis/googleapis-gen@4075a85
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDA3NWE4NTE0ZjY3NjY5MWVjMTU2Njg4YTViYmYxODNhYTk4OTNjZSJ9

fix(v4beta1): remove Application and Profile services and and related protos, enums, and messages
PiperOrigin-RevId: 453241222

Source-Link: googleapis/googleapis@7837470

Source-Link: googleapis/googleapis-gen@ae2c052
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWUyYzA1Mjc0MzcwNjE2MWFjOTVhZGM1MDQ4YWQ1YTNkZThhNjU4NSJ9
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(deps): Update nox in .kokoro/requirements.in [autoapprove] (#254)
6627cf2 
Source-Link: https://github.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
parthea added a commit that referenced this pull request Jun 4, 2023
@dandhlee @parthea
chore: update doc links from googleapis.dev to cloud.google.com (#254)
e21831c 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.2 (#254)
49d69a6 
* chore: Update gapic-generator-python to v1.8.2

PiperOrigin-RevId: 504289125

Source-Link: googleapis/googleapis@38a48a4

Source-Link: googleapis/googleapis-gen@b2dc226
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Jul 6, 2023
@gcf-owl-bot @parthea
chore: store artifacts in placer [autoapprove] (#254)
20a6f2c 
* chore: store artifacts in placer

Source-Link: googleapis/synthtool@cb96037
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd

* revert

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Aug 15, 2023
@gcf-owl-bot
chore: update copyright year to 2022 (#254)
51631b7 
* chore: disable Python snippetgen for bigtable

PiperOrigin-RevId: 431126635

Source-Link: googleapis/googleapis@dbfbfdb

Source-Link: googleapis/googleapis-gen@4b4a4e7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGI0YTRlN2ZlYzczYzYwOTEzZDhiMTA2MWYwYjI5YWZmYjFlMmE3MiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 15, 2023
@renovate-bot
chore(deps): update dependency google-cloud-iam to v2.10.0 (#254)
2840c1c
parthea pushed a commit that referenced this pull request Sep 14, 2023
@gcf-owl-bot
build: [autoapprove] bump cryptography from 41.0.2 to 41.0.3 (#254)
febef00 
Source-Link: https://github.com/googleapis/synthtool/commit/352b9d4c068ce7c05908172af128b294073bf53c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@martini9393
feat: add sample code for using regional Dialogflow endpoint (#254)
b561392 
* Add sample code for using regional dialogflow endpoint

* Update comment

* udpate some styles based on last round of reviews

* run blacken to reformat files and update remaining string formatting

Co-authored-by: Ye Yuan <yuanye@google.com>
parthea added a commit that referenced this pull request Sep 22, 2023
@release-please @parthea
chore(main): release 1.6.2 (#254)
0873fd9 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 2.10.8 (#254)
52e89b7 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-auth to v2.0.2 (#254)
bcf8183
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
fix(deps): require google-api-core >= 2.8.0 (#254)
96a8dd2 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 459095142

Source-Link: googleapis/googleapis@4f1be99

Source-Link: googleapis/googleapis-gen@ae686d9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWU2ODZkOWNkZTRmYzNlMzZkMGFjMDJlZmI4NjQzYjE1ODkwYzFlZCJ9

feat: add audience parameter
PiperOrigin-RevId: 456827138

Source-Link: googleapis/googleapis@23f1a15

Source-Link: googleapis/googleapis-gen@4075a85
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDA3NWE4NTE0ZjY3NjY5MWVjMTU2Njg4YTViYmYxODNhYTk4OTNjZSJ9
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): add nox session to sort python imports (#254)
598036a 
Source-Link: googleapis/synthtool@1b71c10
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 22, 2023
@parthea
chore: update .repo-metadata.json (#254)
c506e13
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: [autoapprove] Update black and isort to latest versions (#254
281d702 
)

Source-Link: https://github.com/googleapis/synthtool/commit/0c7b0333f44b2b7075447f43a121a12d15a7b76a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:08e34975760f002746b1d8c86fdc90660be45945ee6d9db914d1508acdf9a547
parthea added a commit that referenced this pull request Oct 21, 2023
@parthea @gcf-owl-bot
chore: allow releases on previous major versions (#254)
a0ab5db 
* chore: allow releases on previous major versions

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@release-please @parthea
chore(main): release 2.7.2 (#254)
670bfc0 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore: release 2.8.0 (#254)
7969fc0 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.8.0](https://www.github.com/googleapis/python-monitoring/compare/v2.7.0...v2.8.0) (2021-11-16)


### Features

* Added support for auto-close configurations ([#253](https://www.github.com/googleapis/python-monitoring/issues/253)) ([0541c7a](https://www.github.com/googleapis/python-monitoring/commit/0541c7acc69465030077b5ce3b1d9c40cea7b634))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea added a commit that referenced this pull request Oct 21, 2023
@nicain @parthea
Fix: #254 by increasing timeout, use backoff module instead of flaky (#…
0692c9d 
…271)

* feat: use backoff module instead of flaky

* Updates after PR review

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore: release 2.6.0 (#254)
73c4d86 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.6.0](https://www.github.com/googleapis/python-vision/compare/v2.5.0...v2.6.0) (2021-10-20)


### Features

* add support for python 3.10 ([#253](https://www.github.com/googleapis/python-vision/issues/253)) ([7d5e27a](https://www.github.com/googleapis/python-vision/commit/7d5e27af26b13e1854c50f2ff7a7bdd7feea7b0a))


### Documentation

* **readme:** add pylint limitations ([#246](https://www.github.com/googleapis/python-vision/issues/246)) ([e4fb61f](https://www.github.com/googleapis/python-vision/commit/e4fb61f276f4540149884e8098fc4575f30ec9a6))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: remove 'pip install' statements from python_library templates …
1957e43 
…[autoapprove] (#254)

Source-Link: googleapis/synthtool@1f37ce7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086
parthea pushed a commit that referenced this pull request Oct 21, 2023
@SurferJeffAtGoogle
chore: relocate owl bot post processor (#254)
67c53ae 
chore: relocate owl bot post processor
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): refactor unit / system test dependency install (#254)
3e38dc0 
Source-Link: googleapis/synthtool@993985f
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1894490910e891a385484514b22eb5133578897eb5b3c380e6d8ad475c6647cd
parthea pushed a commit that referenced this pull request Oct 22, 2023
@release-please
chore(main): release 1.10.2 (#254)
3778538 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
build(deps): [autoapprove] bump pygments from 2.13.0 to 2.15.0 (#254)
1556fb4 
Source-Link: googleapis/synthtool@eaef28e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.4 (#254)
976ad2f 
* chore: Update gapic-generator-python to v1.8.4

PiperOrigin-RevId: 507808936

Source-Link: googleapis/googleapis@64cf849

Source-Link: googleapis/googleapis-gen@53c48ca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-trace to v1.7.1 (#254)
68b6377
parthea pushed a commit that referenced this pull request Oct 31, 2023
@gcf-owl-bot
build(deps): bump requests to 2.31.0 [autoapprove] (#254)
3119435 
Source-Link: https://github.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure deep copy is correctly performed in datastore.query.Query._clone
3 participants
@tseaver @coveralls @dhermes