Fix #170: handle namespaces in queries

[tseaver]

Review this PR after #254 is merged (it is based from that branch).

Fixes #170.

[coveralls]

Coverage remained the same when pulling 3b582a7 on tseaver:170-query_namespaces into 906700b on GoogleCloudPlatform:master.

[tseaver]

Merged from the trunk: the earlier changesets (from PR #253) are now gone from the diff.

[coveralls]

Coverage remained the same when pulling 8a4ee61 on tseaver:170-query_namespaces into 83e8262 on GoogleCloudPlatform:master.

[tseaver]

Now rebased for your viewing pleasure.

[coveralls]

Coverage remained the same when pulling 7820d91 on tseaver:170-query_namespaces into 83e8262 on GoogleCloudPlatform:master.

[dhermes]

It seems namespace would occur in more places. Did you systematically go through methods with grep or something? In other words, do we have some way of knowing this is comprehensive?

[tseaver]

I looked at all the places that 'namespace' appeared in the protobuf spec, and verified that we were handling all of them:

• 'namespace' is a field in the PartitionId struct
• That struct occurs only as a field of Key objects and a field of RunQueryRequest

We are handling those cases with this change.

[tseaver]

I have rebased to fix the merge conflicts.

[coveralls]

Coverage remained the same when pulling bfffdbf on tseaver:170-query_namespaces into 86b308a on GoogleCloudPlatform:master.

[dhermes]

From viewing the discovery doc it seems the namespace can be included in the key as well.

Otherwise LGTM

[tseaver]

Right, but we already allow for passing the namespace to the Key ctor, setting / geting it through a 'namespace' method, and copying it to / from the PartitionId protobuf element. It was only the 'run_query' bits which lacked support until this PR.