Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing get_credentials() from core. #3667

Merged
merged 2 commits into from
Jul 25, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 25, 2017

In the process also:

  • Slight re-org on nox.py config (to pass posargs) for core and datastore
  • Getting rid of last usage of _Monkey in datastore

This is part of @jonparrott's effort to slim down / stabilize core.


Temporarily labeled "do not merge" so we can discuss "churn" first.

@dhermes dhermes added api: bigtable Issues related to the Bigtable API. api: datastore Issues related to the Datastore API. api: spanner Issues related to the Spanner API. api: core do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 25, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2017
@@ -135,7 +135,7 @@ def __init__(self, credentials=None, _http=None):
credentials, google.auth.credentials.Credentials)):
raise ValueError(_GOOGLE_AUTH_CREDENTIALS_HELP)
if credentials is None and _http is None:
credentials = get_credentials()
credentials, _ = google.auth.default()

This comment was marked as spam.

This comment was marked as spam.

In the process also:

- Slight re-org on `nox.py` config (to pass posargs) for `core`
  and `datastore`
- Getting rid of last usage of `_Monkey` in datastore

This is part of `@jonparrott`'s effort to slim down / stabilize
`core`.
@dhermes dhermes force-pushed the remove-get_credentials branch from f040a4e to bca6b7a Compare July 25, 2017 20:13
@dhermes
Copy link
Contributor Author

dhermes commented Jul 25, 2017

Rebased after #3668 was merged (so now google.cloud.credentials is gone)

@dhermes dhermes merged commit 2083542 into googleapis:master Jul 25, 2017
@dhermes dhermes deleted the remove-get_credentials branch July 25, 2017 21:13
@dhermes dhermes removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 25, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
* Removing `get_credentials()` from `core`.

In the process also:

- Slight re-org on `nox.py` config (to pass posargs) for `core`
  and `datastore`
- Getting rid of last usage of `_Monkey` in datastore

This is part of `@jonparrott`'s effort to slim down / stabilize
`core`.

* Removing `google.cloud.credentials` module from docs.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
* Removing `get_credentials()` from `core`.

In the process also:

- Slight re-org on `nox.py` config (to pass posargs) for `core`
  and `datastore`
- Getting rid of last usage of `_Monkey` in datastore

This is part of `@jonparrott`'s effort to slim down / stabilize
`core`.

* Removing `google.cloud.credentials` module from docs.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
* Removing `get_credentials()` from `core`.

In the process also:

- Slight re-org on `nox.py` config (to pass posargs) for `core`
  and `datastore`
- Getting rid of last usage of `_Monkey` in datastore

This is part of `@jonparrott`'s effort to slim down / stabilize
`core`.

* Removing `google.cloud.credentials` module from docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. api: core api: datastore Issues related to the Datastore API. api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants