Cherry pick cleanups from #499. #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rework '_require_dataset' -> '_require_dataset_id'. Also, make both it and '_require_connection' take the passed object, and test explicitly against None. - Docstring tweaks to reflect API reshapings. - Clarify implicit environ tests. - Clarify dependency on implicit environ in key tests.
| @@ -418,7 +416,7 @@ def save_entity(self, dataset_id, key_pb, properties, | |||
| not passed in 'properties' no longer be set for the entity. | |||
|
|
|||
| :type dataset_id: string | |||
| :param dataset_id: The dataset in which to save the entity. | |||
| :param dataset_id: The id of the dataset in which to save the entity. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
Addresses: #501 (comment)
When used as an abbreviation for 'identifier', rather than to refer to methods named 'id'.
|
|
||
| def test_ctor_w_implicit_dataset_id_empty_path(self): | ||
| _DATASET = 'DATASET' | ||
| self.assertRaises(ValueError, self._makeOne, dataset=_DATASET) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Your favorite: Suggest just lining up with word / line beginning. |
|
LGTM pending lint issues. Also probably worth fixing the kw |
Addresses: #501 (diff)
tseaver
added a commit
that referenced
this pull request
Jan 7, 2015
Cherry pick cleanups from #499.
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
parthea
pushed a commit
that referenced
this pull request
Aug 15, 2023
…p/templates/python_library/.kokoro (#501) Source-Link: https://github.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
Source-Link: googleapis/synthtool@eb78c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163
parthea
added a commit
that referenced
this pull request
Sep 22, 2023
…501) * Repo clean-up * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Rename samples/README.md to samples/snippets/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
added a commit
that referenced
this pull request
Oct 21, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require_dataset_idand '_require_connection' take the passed object, and test explicitly against None.