Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick cleanups from #499. #501

Merged
merged 7 commits into from
Jan 7, 2015
Merged

Cherry pick cleanups from #499. #501

merged 7 commits into from
Jan 7, 2015

Commits on Jan 7, 2015

  1. Cherry pick cleanups from #499. 

    - Rework '_require_dataset' -> '_require_dataset_id'.

  Also, make both it and '_require_connection' take the passed object,
  and test explicitly against None.

- Docstring tweaks to reflect API reshapings.

- Clarify implicit environ tests.

- Clarify dependency on implicit environ in key tests.
    @tseaver
    tseaver committed Jan 7, 2015
    Configuration menu
    Copy the full SHA
    690b5d9 View commit details
    Browse the repository at this point in the history

  2. Valet service.

    @tseaver
    tseaver committed Jan 7, 2015
    Configuration menu
    Copy the full SHA
    f299d31 View commit details
    Browse the repository at this point in the history

  3. Replace most monkeys of implicit environ w/ explicit dataset IDs. 

    Addresses:
#501 (comment)
    @tseaver
    tseaver committed Jan 7, 2015
    Configuration menu
    Copy the full SHA
    e117ca0 View commit details
    Browse the repository at this point in the history

  4. Use correct Sphinx role. 

    Addresses:
#501 (comment)
    @tseaver
    tseaver committed Jan 7, 2015
    Configuration menu
    Copy the full SHA
    eead3e1 View commit details
    Browse the repository at this point in the history

  5. Use 'ID' instead of 'id' consistently in docstrings. 

    When used as an abbreviation for 'identifier', rather than to refer to
methods named 'id'.
    @tseaver
    tseaver committed Jan 7, 2015
    Configuration menu
    Copy the full SHA
    6a87fba View commit details
    Browse the repository at this point in the history

  6. Typo. 

    Addresses:

#501 (diff)
    @tseaver
    tseaver committed Jan 7, 2015
    Configuration menu
    Copy the full SHA
    a87a143 View commit details
    Browse the repository at this point in the history

  7. Chixen bonez.

    @tseaver
    tseaver committed Jan 7, 2015
    Configuration menu
    Copy the full SHA
    90829f5 View commit details
    Browse the repository at this point in the history