Restore 'Dataset' class. #660

tseaver · 2015-02-17T20:21:40Z

Wrapper around 'datastore.api.{get,put,delete}', plus the 'Key',
'Batch', 'Transaction', and 'Query' factories.

@jgeewax

Wrapper around 'datastore.api.{get,put,delete}', plus the 'Key', 'Batch', 'Transaction', and 'Query' factories. Per @jgeewax in #659.

gcloud/datastore/dataset.py

+
+
+class Dataset(object):
+


dhermes · 2015-02-17T20:26:08Z

LGTM pending Travis / comment

We should let @jgeewax sign off as well.

I don't like the factories but it makes sense in context and is certainly the lowest overhead answer

dhermes · 2015-02-17T20:29:43Z

Slight retraction of LGTM: we should have an optional connection on the object

(Reviewing from phone)

coveralls · 2015-02-17T20:58:38Z

Changes Unknown when pulling c368db3 on tseaver:659-dataset-revenant into * on GoogleCloudPlatform:master*.

tseaver · 2015-02-17T21:00:57Z

@dhermes if the user passes no connection to the ctor, would you see it looking one up from the implicit environ, or just passing None through to the wrapped APIs?

Pass it through to the API methods, rather than having the caller pass it. Don't try to resolve it if None is passed (the API methods do that for us).

tseaver · 2015-02-17T23:41:39Z

317ddfd assumes the second option I described.

coveralls · 2015-02-17T23:43:51Z

Changes Unknown when pulling 317ddfd on tseaver:659-dataset-revenant into * on GoogleCloudPlatform:master*.

dhermes · 2015-02-17T23:46:28Z

@tseaver just wrapping up teaching for the day.

I did mean the option you chose but did not mean that connection should be removed from the signatures. However after thinking about it, ISTM that is the right choice. I.E. the dataset should not have a connection overridden as an option, so either pass to constructor or never use.

dhermes · 2015-02-17T23:47:23Z

After this is in I'll try to put together my vision for lazy loaded defaults

[ci skip]

tseaver · 2015-02-18T03:46:26Z

@jgeewax PTAL

gcloud/datastore/dataset.py

+        Passes our ``dataset_id``.
+        """
+        dataset_id = kwargs.pop('dataset_id', None)
+        if dataset_id not in (None, self.dataset_id):


Per: https://github.com/GoogleCloudPlatform/gcloud-python/pull/660/files#r24880209.

Per: https://github.com/GoogleCloudPlatform/gcloud-python/pull/660/files#r24880190

Per: https://github.com/GoogleCloudPlatform/gcloud-python/pull/660/files#r24897521

gcloud/datastore/dataset.py

+        Passes our ``dataset_id``.
+        """
+        if 'dataset_id' in kwargs:
+            raise TypeError('Cannot pass dataset_id')


coveralls · 2015-02-18T16:59:14Z

Changes Unknown when pulling 3d2699e on tseaver:659-dataset-revenant into * on GoogleCloudPlatform:master*.

dhermes · 2015-02-18T17:19:00Z

LGTM pending Sphinx links to the classes. We can merge after, yes?

[ci skip]

Restore 'Dataset' class.

dhermes · 2015-02-18T18:00:35Z

@tseaver Can you give an FYI / heads up when using [ci skip]?

dhermes · 2015-02-18T18:01:48Z

@tseaver I'm gonna to submit a bunch of bite-sized PRs removing _implicit_environ and putting it all in dataset. SGTY?

tseaver · 2015-02-18T18:03:17Z

Re: [ci skip]: the change was docstring-only, and I ran tox -e lint on it locally first. What kind of heads up did you want (you said, "LGTM pending Sphinx links to the classes. We can merge after, yes?").

tseaver · 2015-02-18T18:04:54Z

Re: the PRs moving _implicit_environ to dataset: I guess I will have to see it -- I don't have the sense of it swapped in.

dhermes · 2015-02-18T18:05:01Z

Just an "FYI: docstring only change, I used [ci skip]" (I agree it's totally valid)

elibixby · 2015-02-18T19:06:51Z

This looks great guys.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Restore 'Dataset' class.

d534fbf

Wrapper around 'datastore.api.{get,put,delete}', plus the 'Key', 'Batch', 'Transaction', and 'Query' factories. Per @jgeewax in #659.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2015

dhermes reviewed Feb 17, 2015
View reviewed changes

gcloud/datastore/dataset.py

class Dataset(object):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Add class docstring.

c368db3

Hold an optional connection on the dataset.

317ddfd

Pass it through to the API methods, rather than having the caller pass it. Don't try to resolve it if None is passed (the API methods do that for us).

Add ctor args to class docstring.

bb07591

[ci skip]

dhermes added the api: datastore Issues related to the Datastore API. label Feb 18, 2015

dhermes reviewed Feb 18, 2015
View reviewed changes

tseaver added 4 commits February 18, 2015 09:15

pylint: whitespace.

2268a56

Use kwargs to call 'api.get|put|delete'.

2f269ae

Per: https://github.com/GoogleCloudPlatform/gcloud-python/pull/660/files#r24880209.

Raise TypeError if any 'dataset_id' passed to 'dataaset.key()'.

a14a936

Per: https://github.com/GoogleCloudPlatform/gcloud-python/pull/660/files#r24880190

Convert 'Dataset.query' to use only **kwargs.

3d2699e

Per: https://github.com/GoogleCloudPlatform/gcloud-python/pull/660/files#r24897521

dhermes reviewed Feb 18, 2015
View reviewed changes

dhermes mentioned this pull request Feb 18, 2015

Lazy load defaults #657

Closed

Fix Sphinx roles for classes.

510836a

[ci skip]

tseaver added a commit that referenced this pull request Feb 18, 2015

Merge pull request #660 from tseaver/659-dataset-revenant

018b467

Restore 'Dataset' class.

tseaver merged commit 018b467 into googleapis:master Feb 18, 2015

tseaver deleted the 659-dataset-revenant branch February 18, 2015 17:59

tseaver mentioned this pull request Feb 18, 2015

How do I write code that talks to two different datasets with two different sets of credentials? #659

Closed

dhermes mentioned this pull request Feb 25, 2015

Upgrading version to 0.4.2. #678

Merged

vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023

chore(main): release 2.23.3 (#660)

eb20954

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restore 'Dataset' class. #660

Restore 'Dataset' class. #660

tseaver commented Feb 17, 2015

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Feb 17, 2015

dhermes commented Feb 17, 2015

coveralls commented Feb 17, 2015

tseaver commented Feb 17, 2015

tseaver commented Feb 17, 2015

coveralls commented Feb 17, 2015

dhermes commented Feb 17, 2015

dhermes commented Feb 17, 2015

tseaver commented Feb 18, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Feb 18, 2015

dhermes commented Feb 18, 2015

dhermes commented Feb 18, 2015

dhermes commented Feb 18, 2015

tseaver commented Feb 18, 2015

tseaver commented Feb 18, 2015

dhermes commented Feb 18, 2015

elibixby commented Feb 18, 2015

Restore 'Dataset' class. #660

Restore 'Dataset' class. #660

Conversation

tseaver commented Feb 17, 2015

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Feb 17, 2015

dhermes commented Feb 17, 2015

coveralls commented Feb 17, 2015

tseaver commented Feb 17, 2015

tseaver commented Feb 17, 2015

coveralls commented Feb 17, 2015

dhermes commented Feb 17, 2015

dhermes commented Feb 17, 2015

tseaver commented Feb 18, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Feb 18, 2015

dhermes commented Feb 18, 2015

dhermes commented Feb 18, 2015

dhermes commented Feb 18, 2015

tseaver commented Feb 18, 2015

tseaver commented Feb 18, 2015

dhermes commented Feb 18, 2015

elibixby commented Feb 18, 2015