Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore 'Dataset' class. #660

Merged
merged 9 commits into from
Feb 18, 2015
Merged

Restore 'Dataset' class. #660

merged 9 commits into from
Feb 18, 2015

Commits on Feb 17, 2015

  1. Restore 'Dataset' class. 

    Wrapper around 'datastore.api.{get,put,delete}', plus the 'Key',
'Batch', 'Transaction', and 'Query' factories.

Per @jgeewax in #659.
    @tseaver
    tseaver committed Feb 17, 2015
    Configuration menu
    Copy the full SHA
    d534fbf View commit details
    Browse the repository at this point in the history

  2. Add class docstring.

    @tseaver
    tseaver committed Feb 17, 2015
    Configuration menu
    Copy the full SHA
    c368db3 View commit details
    Browse the repository at this point in the history

  3. Hold an optional connection on the dataset. 

    Pass it through to the API methods, rather than having the caller pass it.

Don't try to resolve it if None is passed (the API methods do that for us).
    @tseaver
    tseaver committed Feb 17, 2015
    Configuration menu
    Copy the full SHA
    317ddfd View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2015

  1. Add ctor args to class docstring. 

    [ci skip]
    @tseaver
    tseaver committed Feb 18, 2015
    Configuration menu
    Copy the full SHA
    bb07591 View commit details
    Browse the repository at this point in the history

  2. pylint: whitespace.

    @tseaver
    tseaver committed Feb 18, 2015
    Configuration menu
    Copy the full SHA
    2268a56 View commit details
    Browse the repository at this point in the history

  3. Use kwargs to call 'api.get|put|delete'. 

    Per: https://github.com/GoogleCloudPlatform/gcloud-python/pull/660/files#r24880209.
    @tseaver
    tseaver committed Feb 18, 2015
    Configuration menu
    Copy the full SHA
    2f269ae View commit details
    Browse the repository at this point in the history

  4. Raise TypeError if any 'dataset_id' passed to 'dataaset.key()'. 

    Per: https://github.com/GoogleCloudPlatform/gcloud-python/pull/660/files#r24880190
    @tseaver
    tseaver committed Feb 18, 2015
    Configuration menu
    Copy the full SHA
    a14a936 View commit details
    Browse the repository at this point in the history

  5. Convert 'Dataset.query' to use only **kwargs. 

    Per: https://github.com/GoogleCloudPlatform/gcloud-python/pull/660/files#r24897521
    @tseaver
    tseaver committed Feb 18, 2015
    Configuration menu
    Copy the full SHA
    3d2699e View commit details
    Browse the repository at this point in the history

  6. Fix Sphinx roles for classes. 

    [ci skip]
    @tseaver
    tseaver committed Feb 18, 2015
    Configuration menu
    Copy the full SHA
    510836a View commit details
    Browse the repository at this point in the history