Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Move maybe_fail_import() to top level test utils #8840

Merged
merged 2 commits into from
Jul 31, 2019

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jul 31, 2019

Following a recent discussion, this PR moves a test utility from BigQuery to the top-level test utils, since it is considered useful outside of BigQuery, too.

How to test

Primarily verify that the promoted utility function is general enough for the promotion.

@plamut plamut added testing api: bigquery Issues related to the BigQuery API. labels Jul 31, 2019
@plamut plamut requested review from busunkim96 and a team July 31, 2019 10:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2019
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
bigquery/noxfile.py Outdated Show resolved Hide resolved
@plamut plamut requested a review from tseaver July 31, 2019 18:46
@plamut plamut merged commit e688b0e into googleapis:master Jul 31, 2019
@plamut plamut deleted the move-test-util branch July 31, 2019 20:15
@plamut plamut changed the title Move maybe_fail_import() to top level test utils BigQuery: Move maybe_fail_import() to top level test utils Aug 22, 2019
@tseaver
Copy link
Contributor

tseaver commented Jul 7, 2021

FWIW, after two years, there are exactly zero uses of maybe_fail_import outside of the python-bigquery repo.

@plamut
Copy link
Contributor Author

plamut commented Jul 8, 2021

Sounds like we need to run a large-scale AdWords campaign to promote its usage.

@tseaver Are you suggesting that it might be better to move this back to the python-bigquery repo?

@tseaver
Copy link
Contributor

tseaver commented Jul 8, 2021

@plamut

Are you suggesting that it might be better to move this back to the python-bigquery repo?

I'm not sure. I came across it while working on googleapis/python-test-utils#43: the function has no test coverage, which meant that I had to install a development version into a virtualenv along with python-bigquery so that I could test that I didn't break anything.

@plamut
Copy link
Contributor Author

plamut commented Jul 9, 2021

@tseaver I see. Sounds like a one-off (ish) annoyance, thus might not be worth it. We could cover it with tests, however, I'll create a ticket to track it.

Edit: Created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants