chore(bigquery): remove duplicate test dependencies #9503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plamut
added
api: bigquery
googlebot
added
the
cla: yes
tseaver
reviewed
Oct 22, 2019
|
I would argue that dropping |
|
@tseaver I can demote |
plamut
force-pushed
the
bq-noxfile-clean
branch
from
7a1b8c4
to
691e5df
Compare
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
The test_utils dependency is only nedeed for test sessions, but not for some other nox sessions such as "lint" and "docs".
plamut
force-pushed
the
bq-noxfile-clean
branch
from
691e5df
to
4322bd7
Compare
tswast
approved these changes
Oct 22, 2019
tseaver
approved these changes
Oct 24, 2019
|
The Cloud Build test failure is unrelated, currently occurring on all PRs, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9502.
This PR removes redundancy in BigQuery's
noxfilethat results intest_utilsbeing installed twice.(modifying the noxfile directly, as it is not generated by the synth tool in BigQuery)
How to test
snippetsandsystem. You do not have to wait for them to complete, just make sure the setup phase is completed and the relevant tests start running.Actual result (before the fix):
In both cases
test_utilsare installed twice. In the output:Expected result (after the fix):
test_utilsare only installed once in a session.