Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable: 'test_bigtable_create_table' snippet flakes with '504 Deadline Exceeded'. #8889

Merged

Conversation

mf2199
Copy link
Contributor

@mf2199 mf2199 commented Aug 1, 2019

Fixes #8480

We used to observe this issue while working on Bigtable. As per our understanding, this used to occur intermittently when Google Cloud takes longer than expected to create instance or table. So we added some cool down time. Now we have added a retry logic to [exponentially] factor in the cool down time, if the table creation fails. As of right now, the max retry count is 4, though it can be configured.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 1, 2019
@tseaver tseaver changed the title [GCP-8480] Bigtable: 'test_bigtable_create_table' snippet flakes with '504 Deadline Exceeded'. Bigtable: 'test_bigtable_create_table' snippet flakes with '504 Deadline Exceeded'. Aug 1, 2019
@tseaver tseaver added the api: bigtable Issues related to the Bigtable API. label Aug 1, 2019
@tseaver
Copy link
Contributor

tseaver commented Aug 1, 2019

@mf2199 This PR overlaps #8879, which I reviewed today: is there a reason not to have @sangramql add this change there?

@mf2199
Copy link
Contributor Author

mf2199 commented Aug 1, 2019

@tseaver The other PR addresses a different (albeit similar) issue. I've asked @sangramql to review this, he will make the final call (hence the draft version).

bigtable/docs/snippets.py Outdated Show resolved Hide resolved
@mf2199
Copy link
Contributor Author

mf2199 commented Aug 2, 2019

@googlebot I consent.

@sangramql sangramql marked this pull request as ready for review August 5, 2019 10:07
@sangramql
Copy link
Contributor

@googlebot I consent

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 5, 2019
@sangramql sangramql added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2019
@tseaver tseaver merged commit dd4c5a1 into googleapis:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bigtable: 'test_bigtable_create_table' snippet flakes with '504 Deadline Exceeded'.
5 participants