-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bigtable: Create table in create_table test, deadline exceed error fix #7
Conversation
@mf2199 please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this is very simple and straightforward approach, I'm not sure whether this is the best way of dealing with flakes. We need to know and understand the root cause of the flakes. Maybe instead of retries, there's a deadline parameter that can be modified, in which case all these line will be redundant.
You probably know the issue better than anybody, since you spent many hours on it. Please write it up and share your knowledge. As I said before, this information is crucial not only for our Wiki but also for the entire Google developers community in general.
Agree, flakes can be very inconsistent and unpredictable. As I was not able to repro this issue with multiple approaches mentioned below. I tried different approach to hit this issue,
—error—
We used to observe this issue when we used to work on bigtable issues. As per my understanding this used to occur intermittently when Google cloud takes longer than expected to create instance or table. So we added cool down time. |
We have to be careful about how many instances we open, as the API may place hard limits on that! |
This looks like a good write-up to me. We can submit this PR as a "possible" solution, along with all your comments. |
Opened in googleapis#8889, hence closing this. |
[Issue 8480]
Bigtable: 'test_bigtable_create_table' snippet flakes with '504 Deadline Exceeded'.