Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery): fix copy pasta error in import error message (pandas -> pyarrow) #9955

Merged
merged 1 commit into from
Dec 12, 2019
Merged

fix(bigquery): fix copy pasta error in import error message (pandas -> pyarrow) #9955

merged 1 commit into from
Dec 12, 2019

Conversation

mbarkhau
Copy link
Contributor

No description provided.

@mbarkhau mbarkhau requested a review from a team December 10, 2019 17:22
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2019
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2019
@plamut
Copy link
Contributor

plamut commented Dec 11, 2019 •
edited
Loading

Some of the unit tests fail, because the underlying transport is now called with an explicit timeout parameter (even if None by default), causing a mismatch in some of the call assertions.

FWIW, these tests (and several others) will be updated in #9875, but the latter is primarily waiting for new releases of google auth and api core (see its TODO checklist for details).

Update: Fixed in #9961.

@plamut plamut changed the title fix copy pasta: pandas -> pyarrow fix(bigquery): fix copy pasta error in import error message (pandas -> pyarrow) Dec 11, 2019
@plamut plamut added api: bigquery Issues related to the BigQuery API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 11, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 12, 2019
tswast
tswast approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@tswast tswast merged commit eb3713d into googleapis:master Dec 12, 2019
This was referenced Jan 29, 2020
Merged
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mbarkhau @plamut @tswast @googlebot @busunkim96 @yoshi-kokoro