Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bigquery): release 1.23.0 #9961

Merged
merged 3 commits into from
Dec 12, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Dec 11, 2019

This pull request was generated using releasetool.

@tswast tswast requested a review from a team December 11, 2019 21:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2019
bigquery/CHANGELOG.md Outdated Show resolved Hide resolved
@plamut
Copy link
Contributor

plamut commented Dec 11, 2019

Note: Some of the unit tests might fail, because the transport now includes an explicit timeout argument (set to None by default), which breaks a few assertions about the calls made.

Edit: Indeed, three tests failed, because their assertions do not expect that timeout=None is passed to the underlying transport. These tests need to be adjusted.

They are also fixed in #9875, but the latter is currently blocked by another PR to the auth library.

@tswast
Copy link
Contributor Author

tswast commented Dec 11, 2019

Fixed unit test failures in c10002e.

@tswast tswast merged commit 72c1275 into googleapis:master Dec 12, 2019
@yoshi-automation
Copy link
Contributor

@yoshi-automation
Copy link
Contributor

The release build has started, the log can be viewed here. 🌻

@yoshi-automation
Copy link
Contributor

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autorelease: published cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants