Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabling incompatible mutation metrics for HBase 1.3 or lower #3599

Merged
merged 8 commits into from
May 3, 2022

Conversation

vermas2012
Copy link
Member

Due to lack of custom counter support in HBase.

#3596

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@vermas2012 vermas2012 requested a review from a team as a code owner May 2, 2022 20:38
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable-hbase API. labels May 2, 2022
@vermas2012 vermas2012 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2022
@vermas2012 vermas2012 changed the title Disabling incompatible mutation metrics for HBase 1.3 or lower fix: disabling incompatible mutation metrics for HBase 1.3 or lower May 2, 2022
@vermas2012 vermas2012 requested a review from mutianf May 3, 2022 00:42
@vermas2012 vermas2012 self-assigned this May 3, 2022
@vermas2012 vermas2012 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2022
Copy link
Contributor

@mutianf mutianf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vermas2012 vermas2012 added the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2022
vermas2012 and others added 4 commits May 3, 2022 10:36
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Due to a bug in maven shade plugin 3.3.0,  compile dependencies got stripped from bigtable-beam-import. This bug only affects artifacts where shadedArtifactAttached=true.

Reference: https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-419
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@vermas2012 vermas2012 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2022
@vermas2012 vermas2012 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9a693e8 into googleapis:main May 3, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2022
@vermas2012 vermas2012 deleted the metrics branch May 3, 2022 18:16
gcf-merge-on-green bot pushed a commit that referenced this pull request May 3, 2022
🤖 I have created a release *beep* *boop*
---


## [2.2.0](v2.1.1...v2.2.0) (2022-05-03)


### Features

* log version and settings on startup ([#3601](#3601)) ([109023a](109023a))
* next release from main branch is 2.2.0 ([#3593](#3593)) ([58a6ce4](58a6ce4))


### Bug Fixes

* re-add missing dependencies for unshaded bigtable-beam-import jar ([#3600](0dfb130)
* disabling incompatible mutation metrics for HBase 1.3 or lower ([#3599](#3599)) ([9a693e8](9a693e8))
* published dependencies of bigtable-beam-import ([#3600](#3600)) ([0dfb130](0dfb130))


### Dependencies

* update dependency net.bytebuddy:byte-buddy to v1.12.10 ([#3597](#3597)) ([283cef8](283cef8))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants