docs: Expand hello world snippet to show how to access specific cells #516

dmitry-fa · 2020-11-09T13:40:43Z

Fixes #473

…lls by family & qualifier

snippet-bot · 2020-11-09T13:40:54Z

Here is the summary of changes.

You added 1 region tag.

samples/snippets/src/main/java/com/m/examples/bigtable/HelloWorld.java:168, tag bigtable_hw_get_by_key_veneer

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

codecov · 2020-11-09T13:48:46Z

Codecov Report

Merging #516 (22d482a) into master (45535c4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #516   +/-   ##
=========================================
  Coverage     81.31%   81.31%           
  Complexity     1128     1128           
=========================================
  Files           106      106           
  Lines          7042     7042           
  Branches        368      368           
=========================================
  Hits           5726     5726           
  Misses         1119     1119           
  Partials        197      197

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45535c4...22d482a. Read the comment docs.

dmitry-fa · 2020-11-09T13:58:03Z

Questions/comments which arose in the process of handling this issue:

There is no documentation on how to build samples. I used the following command:

#> cd samples/snippets
#> GOOGLE_CLOUD_PROJECT=my-project BIGTABLE_TESTING_INSTANCE=my-insntance mvn clean verify

All tests pass except one: Quickstart, which expects a certain table to exist
A number of tests produce:

io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference cleanQueue
SEVERE: *~*~*~ Channel ManagedChannelImpl{logId=7, target=bigtableadmin.googleapis.com:443} was not shutdown properly!!! ~*~*~*

currently fixed for HelloWorld only. Should it be fixed for other tests?

Formatter could be used to clean up the coding style

billyjacobson

Great and thanks for getting tests added

eaball35 · 2020-12-16T17:56:19Z

igorbernstein2

lgtm!

igorbernstein2 · 2020-12-17T00:53:20Z

@kolea2 I think this requires your approval

dmitry-fa · 2020-12-21T17:02:51Z

@kolea2 gentle ping

…googleapis#516) * samples: Expand hello world snippet to show how to access specific cells by family & qualifier * samples: Expand hello world snippet to show how to access specific cells by family & qualifier

dmitry-fa added 2 commits November 9, 2020 15:20

samples: Expand hello world snippet to show how to access specific ce…

4fcbb7e

…lls by family & qualifier

samples: Expand hello world snippet to show how to access specific ce…

22d482a

…lls by family & qualifier

dmitry-fa requested a review from a team November 9, 2020 13:40

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2020

product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Nov 9, 2020

dmitry-fa changed the title ~~Snippet helloworld~~ samples: Expand hello world snippet to show how to access specific cells Nov 9, 2020

dmitry-fa requested review from igorbernstein2 and kolea2 November 9, 2020 13:45

kolea2 requested a review from billyjacobson November 9, 2020 18:00

billyjacobson approved these changes Nov 9, 2020

View reviewed changes

kolea2 mentioned this pull request Nov 13, 2020

beam export job leaks grpc connections googleapis/java-bigtable-hbase#2504

Closed

product-auto-label bot added the samples Issues that are directly related to samples. label Nov 16, 2020

igorbernstein2 approved these changes Dec 17, 2020

View reviewed changes

igorbernstein2 changed the title ~~samples: Expand hello world snippet to show how to access specific cells~~ docs: Expand hello world snippet to show how to access specific cells Dec 17, 2020

blunderbuss-gcf bot assigned kolea2 Dec 17, 2020

igorbernstein2 approved these changes Dec 17, 2020

View reviewed changes

kolea2 approved these changes Dec 21, 2020

View reviewed changes

kolea2 merged commit a9001a8 into googleapis:master Dec 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Expand hello world snippet to show how to access specific cells #516

docs: Expand hello world snippet to show how to access specific cells #516

dmitry-fa commented Nov 9, 2020

snippet-bot bot commented Nov 9, 2020 •

edited

Loading

codecov bot commented Nov 9, 2020 •

edited

Loading

dmitry-fa commented Nov 9, 2020

billyjacobson left a comment

eaball35 commented Dec 16, 2020

igorbernstein2 left a comment

igorbernstein2 commented Dec 17, 2020

dmitry-fa commented Dec 21, 2020

docs: Expand hello world snippet to show how to access specific cells #516

docs: Expand hello world snippet to show how to access specific cells #516

Conversation

dmitry-fa commented Nov 9, 2020

snippet-bot bot commented Nov 9, 2020 • edited Loading

codecov bot commented Nov 9, 2020 • edited Loading

Codecov Report

dmitry-fa commented Nov 9, 2020

billyjacobson left a comment

Choose a reason for hiding this comment

eaball35 commented Dec 16, 2020

igorbernstein2 left a comment

Choose a reason for hiding this comment

igorbernstein2 commented Dec 17, 2020

dmitry-fa commented Dec 21, 2020

snippet-bot bot commented Nov 9, 2020 •

edited

Loading

codecov bot commented Nov 9, 2020 •

edited

Loading