-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(samples): split samples into their own files #368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on the first PR in this repo! When filing PRs in nodejs land, we really like to use the conventional commits format. It makes things a lot easier when figuring out what's happening in a change log.
Could you rename this PR (and the resulting commit) to something like:
refactor(samples): split samples into their own files
Thanks!
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 4 4
Lines 544 544
Branches 75 75
=======================================
Hits 541 541
Misses 2 2
Partials 1 1 Continue to review full report at Codecov.
|
Fixes #367