Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(synth): add datastore v1 admin api #686

Merged
merged 3 commits into from
Jun 26, 2020
Merged

Conversation

zamnuts
Copy link
Contributor

@zamnuts zamnuts commented Jun 14, 2020

This is part 1 of 2 for resolving #685:

  • Updates synth to include v1 admin proto generation
  • Exports DatastoreAdminClient

Implementation of RPC manual wrappers will come in a second PR.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2020
@zamnuts zamnuts force-pushed the feature/introduce-admin-v1 branch from 20359f2 to d8fc57d Compare June 17, 2020 21:35
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #686 into master will decrease coverage by 0.54%.
The diff coverage is 97.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
- Coverage   99.40%   98.85%   -0.55%     
==========================================
  Files           7       10       +3     
  Lines        6175     7243    +1068     
  Branches      426      438      +12     
==========================================
+ Hits         6138     7160    +1022     
- Misses         36       81      +45     
- Partials        1        2       +1     
Impacted Files Coverage Δ
src/v1/datastore_admin_client.ts 97.74% <97.74%> (ø)
src/v1/index.ts 100.00% <100.00%> (ø)
.prettierrc.js 0.00% <0.00%> (ø)
.mocharc.js 78.57% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5934686...8ddc031. Read the comment docs.

@zamnuts zamnuts force-pushed the feature/introduce-admin-v1 branch from b6d3ab4 to 8ddc031 Compare June 22, 2020 18:19
@zamnuts zamnuts merged commit 25d6582 into master Jun 26, 2020
@stephenplusplus stephenplusplus deleted the feature/introduce-admin-v1 branch August 10, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants