Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: admin v1 new rpc support #685 - WIP #687

Closed
wants to merge 2 commits into from

Conversation

zamnuts
Copy link
Contributor

@zamnuts zamnuts commented Jun 14, 2020

Should merge #686 first to pick up proto changes.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #685 🦕

Feature completeness status (incl. implementation, tests, samples, sample tests, docs):

  • ImportEntities
  • ExportEntities
  • GetIndex
  • ListIndexes

@zamnuts zamnuts added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 14, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2020
@zamnuts zamnuts changed the title feature/admin v1 new rpc support - WIP feat: admin v1 new rpc support #685 - WIP Jun 17, 2020
@zamnuts zamnuts force-pushed the feature/admin-v1-new-rpc-support branch from ac5304b to 895ca53 Compare June 30, 2020 07:57
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #687 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   98.85%   98.87%   +0.02%     
==========================================
  Files          10       10              
  Lines        7243     7402     +159     
  Branches      438      453      +15     
==========================================
+ Hits         7160     7319     +159     
  Misses         81       81              
  Partials        2        2              
Impacted Files Coverage Δ
src/index.ts 99.74% <100.00%> (+0.04%) ⬆️
src/request.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d6582...b81154d. Read the comment docs.

@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/nodejs-datastore API. label Aug 21, 2020
@sofisl sofisl added sup and removed sup labels Aug 28, 2020
@stephenplusplus
Copy link
Contributor

This work has continued in #734.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce v1 admin RPCs: entities and indexes
4 participants