Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade google-auth-library #1122

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

laljikanjareeya
Copy link
Contributor

Fixes #1121

@laljikanjareeya laljikanjareeya requested review from a team as code owners October 7, 2020 03:01
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #1122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1122   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files          25       25           
  Lines       11066    11066           
  Branches      595      595           
=======================================
  Hits        10821    10821           
  Misses        241      241           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdbe80f...e4326b9. Read the comment docs.

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Oct 7, 2020
@stephenplusplus stephenplusplus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2020
@laljikanjareeya laljikanjareeya added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2020
@laljikanjareeya laljikanjareeya added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2020
@feywind
Copy link
Collaborator

feywind commented Oct 15, 2020

The CI issue on this one isn't related to a problem with the PR. :| Looks like this might be fallout from some sample updates the other day, though I'm unsure why that CI didn't fail. (Maybe the docsite got updated at a different time than the library?)

Copy link
Collaborator

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2020
@laljikanjareeya laljikanjareeya merged commit 54310a7 into googleapis:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@google-cloud/pubsub@2.5.0 includes dependencies with security vulnerabilities
4 participants