Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update synthtool generation for latest changes #1128

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Oct 15, 2020

This is needed to make the CI pass for: #1122

@feywind feywind requested review from a team as code owners October 15, 2020 22:16
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2020
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1128 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1128   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files          25       25           
  Lines       11066    11066           
  Branches      595      546   -49     
=======================================
  Hits        10821    10821           
  Misses        241      241           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c4510...651cdac. Read the comment docs.

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - did we get this in another automated CL?

Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized the pubsub_listen_ordered_messages sample was gone from the docs. Thanks for the update.

@feywind
Copy link
Collaborator Author

feywind commented Oct 15, 2020

@JustinBeckwith There was an old synthtool PR that must've been blocking the generation of a new one? I just closed that one out and manually ran it.

@feywind feywind merged commit bdbe80f into googleapis:master Oct 15, 2020
@feywind feywind deleted the update-synthtool branch October 15, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants