feat: Add additional parameters to to_json() and to_dict() methods
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- These parameters are just passthroughs to [`MessageToJson`][1] and [`MessageToDict`][2] [1]: https://googleapis.dev/python/protobuf/latest/google/protobuf/json_format.html#google.protobuf.json_format.MessageToJson [2]: https://googleapis.dev/python/protobuf/latest/google/protobuf/json_format.html#google.protobuf.json_format.MessageToDict
|
I think Owlbot has to be force run by adding the tag. I don't have permission to do that. |
gcf-owl-bot
bot
removed
the
owlbot:run
|
Is this good for review? |
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
reviewed
Sep 6, 2023
| s = Squid(mass_kg=3.14159265) | ||
|
|
||
| s_dict = Squid.to_dict(s, float_precision=3) | ||
| assert s_dict["mass_kg"] == 3.14 |
There was a problem hiding this comment.
I would have expected this to be 3.141 or 3.142 since float_precision=3. If you agree, can you file a bug and add a comment?
There was a problem hiding this comment.
Ok, I filed #390
Should it block this PR?
parthea
approved these changes
Sep 8, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageToJsonandMessageToDict