-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add additional parameters to to_json()
and to_dict()
methods
#384
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9522581
feat: Add additional parameters to `to_json()` and `to_dict()` methods
holtskinner a81ee7c
chore: Update min protobuf version to 3.20.0 to support `ensure_ascii`
holtskinner 4b54464
Removed `ensure_ascii` to prevent version compatibility errors
holtskinner c9a990c
Update proto/message.py
holtskinner c843a77
test: Add tests for `sort_keys` and `float_precision`
holtskinner ec014f6
Fix test checks
holtskinner f890177
Remove indent from float_precision test and add re.compile to sortkey…
holtskinner 0137ab3
Add spaces to float precision check, add dotall to sortkeys check
holtskinner eaf901b
Remove indent from sort_keys test, add space to float precision test
holtskinner 4b7b1e2
Changed match to search
holtskinner eea1fe6
test: Add test for `to_dict()` with `float_precision`
holtskinner 5456326
Added TODOs for `float_precision` issue
holtskinner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected this to be
3.141
or3.142
sincefloat_precision=3
. If you agree, can you file a bug and add a comment?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I filed #390
Should it block this PR?