Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: failing test test_load_chunks_omits_policy_tags #387

Closed
tswast opened this issue Sep 21, 2021 · 0 comments · Fixed by #388
Closed

regression: failing test test_load_chunks_omits_policy_tags #387

tswast opened this issue Sep 21, 2021 · 0 comments · Fixed by #388
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tswast
Copy link
Collaborator

tswast commented Sep 21, 2021

https://app.circleci.com/pipelines/github/tswast/python-bigquery-pandas/193/workflows/020984af-b902-43de-8d54-28132cc5835e/jobs/1173

This could mean that the fix in #356 got lost somehow? Or perhaps broken by a recent google-cloud-bigquery release?

@tswast tswast added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 21, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Sep 21, 2021
@tswast tswast self-assigned this Sep 21, 2021
gcf-merge-on-green bot pushed a commit to googleapis/python-bigquery that referenced this issue Sep 24, 2021
…gs (#983)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #981 
Fixes #982
Towards googleapis/python-bigquery-pandas#387
🦕
judahrand pushed a commit to judahrand/python-bigquery that referenced this issue Sep 27, 2021
…gs (googleapis#983)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes googleapis#981 
Fixes googleapis#982
Towards googleapis/python-bigquery-pandas#387
🦕
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 25, 2021
There need to be some changes in `google-cloud-bigquery` for this fix: googleapis/python-bigquery#703 (comment) (Update: Done!)

Closes #387
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this issue Apr 17, 2023
…gs (googleapis#983)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes googleapis#981 
Fixes googleapis#982
Towards googleapis/python-bigquery-pandas#387
🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant