Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: blacken with 19.10b0 to match shared templates #386

Merged
merged 2 commits into from
Sep 21, 2021
Merged

chore: blacken with 19.10b0 to match shared templates #386

merged 2 commits into from
Sep 21, 2021

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Sep 21, 2021 •
edited
Loading

Towards #367

@tswast tswast requested review from a team as code owners September 21, 2021 21:51
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Sep 21, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2021
@tswast
Copy link
Collaborator Author

tswast commented Sep 21, 2021

Failing unit test looks like a real failure to me. Was probably failing before blacken though. Filed #387 to investigate.

@tswast tswast merged commit f4a5f73 into googleapis:main Sep 21, 2021
@tswast tswast deleted the issue367-blacken branch September 21, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@kurtisvg kurtisvg Awaiting requested review from kurtisvg

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @tseaver