Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update error logging when converting to pyarrow column fails #1836

Merged
merged 31 commits into from
Mar 19, 2024

Conversation

chalmerlowe
Copy link
Contributor

@chalmerlowe chalmerlowe commented Feb 29, 2024

When conversion of a pyarrow column fails, the user is not provided adequate information about which column fails to convert. This PR provides additional context to identify the column (if the Series has a .name parameter).

Fixes #1621 🦕
Fixes #1822

This merges and replaces the follow PR(s):
#1824
#1622

@chalmerlowe chalmerlowe requested review from a team as code owners February 29, 2024 16:45
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 29, 2024
@chalmerlowe chalmerlowe requested a review from a team as a code owner February 29, 2024 19:29
@chalmerlowe chalmerlowe marked this pull request as draft February 29, 2024 19:30
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 15, 2024
@chalmerlowe chalmerlowe marked this pull request as ready for review March 18, 2024 14:16
@Linchin
Copy link
Contributor

Linchin commented Mar 18, 2024

Thank you so much @chalmerlowe for fixing these issues! Mostly looks good, I just had some questions on the details.

@chalmerlowe chalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Mar 18, 2024
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 19, 2024
@chalmerlowe chalmerlowe merged commit 0ac6e9b into main Mar 19, 2024
20 checks passed
@chalmerlowe chalmerlowe deleted the name-series-in-error-log branch March 19, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
2 participants