Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: removed pkg_resources from all test files and moved importlib into pandas extra" #1739

Closed
wants to merge 1 commit into from
Closed

Revert "feat: removed pkg_resources from all test files and moved importlib into pandas extra" #1739

wants to merge 1 commit into from

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 28, 2023

Reverts #1726

@tswast tswast requested review from a team as code owners November 28, 2023 22:24
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Nov 28, 2023
parthea
parthea requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss the next step in #1726, or via a new issue in this repo. We need to drop pkg_resources in order to support python 3.12.

@tswast
Copy link
Contributor Author

tswast commented Nov 29, 2023

Removing the unnecessary "editable" install fixes this. googleapis/python-bigquery-dataframes#239 Closing.

@tswast tswast closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea requested changes

@jainsahab jainsahab Awaiting requested review from jainsahab jainsahab is a code owner automatically assigned from googleapis/api-bigquery

@kiraksi kiraksi Awaiting requested review from kiraksi

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @parthea