tests: ensure systests pass under emulator in a clean environment #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, move tests for emulator host to 'test_base_client'. Closes #463.
product-auto-label
bot
added
the
api: firestore
google-cla
bot
added
the
cla: yes
tseaver
added
the
do not merge
tseaver
commented
Sep 29, 2021
| #pull_request | ||
| # branches: | ||
| # - main | ||
| push: # temporary |
There was a problem hiding this comment.
Avoid merging until this is switched to run on PRs, rather than pushes.
I actually expect this to hang, but maybe we get lucky?
crwilcox
reviewed
Sep 29, 2021
Such project IDs cannot be used in real API calls.
crwilcox
approved these changes
Sep 30, 2021
tseaver
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463.
Add a Github Workflow to run the system tests under the emulator.