Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

chore: delete owlbot.py #131

Closed
wants to merge 5 commits into from
Closed

chore: delete owlbot.py #131

wants to merge 5 commits into from

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 27, 2021

Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2021
@parthea parthea requested a review from a team as a code owner October 27, 2021 11:16
@product-auto-label product-auto-label bot added the api: iam Issues related to the googleapis/python-iam API. label Oct 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2021
@parthea
Copy link
Contributor Author

parthea commented Oct 27, 2021

TODO: Determine if the changes in this CL would be considered a breaking change as the reference documentation moved from https://github.com/googleapis/python-iam/tree/main/docs/credentials_v1 to https://github.com/googleapis/python-iam/tree/main/docs/iam_credentials_v1

@parthea
Copy link
Contributor Author

parthea commented Oct 27, 2021

Note to self: if this is not a breaking change, send a CL to update the BUILD.bazel file here with the following changes:

--- a/google/iam/credentials/v1/BUILD.bazel
+++ b/google/iam/credentials/v1/BUILD.bazel
@@ -150,6 +150,11 @@ py_gapic_library(
     name = "credentials_py_gapic",
     srcs = [":credentials_proto"],
     grpc_service_config = "iamcredentials_grpc_service_config.json",
+    opt_args = [
+        "warehouse-package-name=google-cloud-iam",
+        "python-gapic-namespace=google.cloud",
+        "python-gapic-name=iam_credentials",
+    ],
 )

@parthea
Copy link
Contributor Author

parthea commented Nov 6, 2021

Wait for cl/408017201

@parthea
Copy link
Contributor Author

parthea commented Nov 10, 2021

Superseded by #136

@parthea parthea closed this Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: iam Issues related to the googleapis/python-iam API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant