Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): Run owlbot_main() when owlbot.py doesn't exist #1244

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 14, 2021

This PR will allow us to remove owlbot.py from python repositories that don't have repository specific owlbot.py customizations.

I tested the changes using the following commands after cloning synthtool

git checkout add-owlbot-main-for-python
docker build -t testowlbotmain -f docker/owlbot/python/Dockerfile .

Once the docker image was built, I ran the following command in the root of python-iap which has no customimzations and python-deploy which has minor customizations. Prior to running these commands, I deleted owlbot.py locally.

docker pull gcr.io/cloud-devrel-public-resources/owlbot-cli:latest
docker run --rm --user $(id -u):$(id -g) -v $(pwd):/repo -w /repo gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-code
docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo testowlbotmain

@parthea parthea requested a review from a team October 14, 2021 14:30
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2021
gcf-merge-on-green bot pushed a commit to googleapis/python-redis that referenced this pull request Oct 27, 2021
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
gcf-merge-on-green bot pushed a commit to googleapis/python-security-private-ca that referenced this pull request Oct 29, 2021
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
gcf-merge-on-green bot pushed a commit to googleapis/python-billingbudgets that referenced this pull request Nov 4, 2021
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Apr 20, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 5, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants