Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up usage of object.__new__ and mocks for Model in ndb unit tests #6

Closed
dhermes opened this issue Nov 16, 2018 · 1 comment · Fixed by #177
Closed

Clean up usage of object.__new__ and mocks for Model in ndb unit tests #6

dhermes opened this issue Nov 16, 2018 · 1 comment · Fixed by #177
Assignees
@chrisrossi
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@dhermes
Copy link
Contributor

dhermes commented Nov 16, 2018

See #6487 for some (but not all) context.
@dhermes dhermes self-assigned this Nov 16, 2018
@crwilcox crwilcox transferred this issue from googleapis/google-cloud-python Feb 21, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 29, 2019
@sduskis sduskis added type: cleanup An internal cleanup or hygiene concern. and removed 🚨 🚨 This issue needs some love. triage me I really want to be triaged. labels May 13, 2019
@chrisrossi
Copy link
Contributor

googleapis/google-cloud-python#6487

chrisrossi pushed a commit to chrisrossi/python-ndb that referenced this issue Aug 28, 2019
Clean up usage of object.__new__ and mocks for Model in unit tests
79553a0 
Fixes googleapis#6
@chrisrossi chrisrossi mentioned this issue Aug 28, 2019
Merged
chrisrossi pushed a commit that referenced this issue Aug 28, 2019
Clean up usage of object.__new__ and mocks for Model in unit tests (#…
8efa318 
…177)

Fixes #6
@justinkwaugh justinkwaugh mentioned this issue May 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisrossi chrisrossi

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up usage of object.__new__ and mocks for Model in unit tests chrisrossi/python-ndb
4 participants
@sduskis @chrisrossi @dhermes @yoshi-automation