Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up usage of object.__new__ and mocks for Model in unit tests #177

Merged
merged 2 commits into from
Aug 28, 2019
Merged

Clean up usage of object.__new__ and mocks for Model in unit tests #177

merged 2 commits into from
Aug 28, 2019

Conversation

chrisrossi
Copy link
Contributor

Fixes #6

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2019
@chrisrossi chrisrossi requested a review from cguardia August 28, 2019 14:18
cguardia
cguardia approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@chrisrossi chrisrossi merged commit 8efa318 into googleapis:master Aug 28, 2019
@chrisrossi chrisrossi deleted the issue-6 branch January 12, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cguardia cguardia cguardia approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up usage of object.__new__ and mocks for Model in ndb unit tests
3 participants
@chrisrossi @cguardia @googlebot