Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Cache: Implement retry for transient errors #601

Closed
chrisrossi opened this issue Feb 11, 2021 · 1 comment
Closed

Global Cache: Implement retry for transient errors #601

chrisrossi opened this issue Feb 11, 2021 · 1 comment
Assignees
@chrisrossi
Labels
api: datastore Issues related to the googleapis/python-ndb API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@chrisrossi
Copy link
Contributor

For transient errors in the global cache, if in strict mode, cache operations should be retried some number of times to avoid raising an exception to the application layer, if possible.

Related to, but different than #564
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Feb 11, 2021
@chrisrossi chrisrossi self-assigned this Feb 11, 2021
@chrisrossi chrisrossi added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 11, 2021
chrisrossi pushed a commit to chrisrossi/python-ndb that referenced this issue Feb 12, 2021
feat: retry global cache operations if there is a transient error in …
a21bb47 
…strict mode

closes googleapis#601
chrisrossi pushed a commit to chrisrossi/python-ndb that referenced this issue Feb 12, 2021
feat: retry global cache operations on transient errors
06791a4 
When an operation on the global cache is tried and there is a transient
error, such as not being able to connect to a Redis or Memcached server,
if the operation is being tried in strict mode, then the operation is
now retried a number of times before the transient error is eventually
raised to the application layer.

Implements googleapis#601
@chrisrossi chrisrossi mentioned this issue Feb 12, 2021
Merged
chrisrossi pushed a commit that referenced this issue Feb 26, 2021
feat: retry global cache operations on transient errors (#603)
5d6b650 
When an operation on the global cache is tried and there is a transient
error, such as not being able to connect to a Redis or Memcached server,
if the operation is being tried in strict mode, then the operation is
now retried a number of times before the transient error is eventually
raised to the application layer.

Implements #601
@chrisrossi
Copy link
Contributor Author

Closed by #603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisrossi chrisrossi

Labels
api: datastore Issues related to the googleapis/python-ndb API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisrossi