feat: retry global cache operations on transient errors #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an operation on the global cache is tried and there is a transient error, such as not being able to connect to a Redis or Memcached server, if the operation is being tried in strict mode, then the operation is now retried a number of times before the transient error is eventually raised to the application layer. Implements googleapis#601
product-auto-label
bot
added
the
api: datastore
google-cla
bot
added
the
cla: yes
|
I didn't make any of this configurable. I figured the users didn't really need the cognitive load. |
|
@andrewsg @crwilcox @craiglabenz PTAL? |
crwilcox
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an operation on the global cache is tried and there is a transient
error, such as not being able to connect to a Redis or Memcached server,
if the operation is being tried in strict mode, then the operation is
now retried a number of times before the transient error is eventually
raised to the application layer.
Implements #601