Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): do not update versions of packages installed using a protocol #2281

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

niieani
Copy link
Contributor

@niieani niieani commented May 4, 2024

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2173 🦕

  • Fixes regression from 16.3.0 by omitting bumping any protocol-based dependencies.
  • Adds a test to make sure the regression doesn't happen again

@kyranjamie
Copy link

Release this please 🙃

@kyranjamie
Copy link

Release this please 🙃 jhgjh

@chingor13 chingor13 merged commit eeb1411 into googleapis:main Jun 6, 2024
11 checks passed
@niieani niieani deleted the fix-non-version-bumps branch June 8, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workspace:* is updated to a specific version when working with pnpm workspace
4 participants