ci: release-please use node workspaces plugin #119
Conversation
|
Warning Rate Limit Exceeded@edgarkhanzadian has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 55 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates involve downgrading the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
edgarkhanzadian
changed the title
|
What do you think should we downgrade the action's version to v3 and use it that way or just wait until they release the fix for it? @fbwoolf @kyranjamie |
edgarkhanzadian
force-pushed
the
ci/release-please-use-node-workspaces-plugin
branch
2 times, most recently
from
454862e
to
eb77028
Compare
|
I'm currently hitting an issue of having multiple versions of the same leather package in extension, so we need this one fixed quickly. I will also now publish all of the packages together to update their dependency versions. 
|
edgarkhanzadian
requested review from
kyranjamie,
pete-watters,
fbwoolf and
alter-eggo
edgarkhanzadian
force-pushed
the
ci/release-please-use-node-workspaces-plugin
branch
from
eb77028
to
270b875
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/release-please.yml (1 hunks)
- packages/models/src/network.model.ts (1 hunks)
- release-please-config.json (1 hunks)
Files skipped from review due to trivial changes (2)
- packages/models/src/network.model.ts
- release-please-config.json
Additional comments not posted (3)
.github/workflows/release-please.yml (3)
18-22: The downgrade torelease-please-action@v3and configuration adjustments appear correctly implemented.Verification successful
The
release-please.ymlfile correctly referencesgoogle-github-actions/release-please-action@v3and includes the necessary configuration adjustments.
- The
release-please-action@v3is used with thecommand: manifest.- The
default-branchis set todev.This confirms that the downgrade and configuration adjustments have been correctly implemented.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the integration of the new configuration in the release-please workflow. # Test: Search for the workflow usage. Expect: Correct behavior as per new configuration. rg --type yaml $'release-please-action@v3'Length of output: 41
Script:
#!/bin/bash # Description: Verify the presence and version of release-please-action in the workflow file. # Test: Search for all instances of release-please-action to check its presence and version. rg --type yaml 'release-please-action'Length of output: 38
Script:
#!/bin/bash # Description: Verify the presence and version of google-github-actions in the workflow file. # Test: Search for all instances of google-github-actions to check its presence and version. rg --type yaml 'google-github-actions'Length of output: 38
Script:
#!/bin/bash # Description: Verify the presence of any GitHub Actions in the workflow file. # Test: Search for all instances of `uses:` to check the presence of any GitHub Actions. rg --type yaml 'uses:'Length of output: 207
Script:
#!/bin/bash # Description: List all files in the .github/workflows directory to verify the presence of the workflow file. # Test: List all files in the .github/workflows directory. ls .github/workflowsLength of output: 57
Script:
#!/bin/bash # Description: Display the content of the release-please.yml file to verify the configuration. # Test: Display the content of the release-please.yml file. cat .github/workflows/release-please.ymlLength of output: 1883
24-36: The commented-out section forrelease-please-action@v4is clear and includes a TODO for future updates. Ensure to monitor the progress of the issue in the linked PR.
36-36: The deployment job configuration looks good and follows best practices for conditional execution based on therelease-pleasejob's output.
edgarkhanzadian
force-pushed
the
ci/release-please-use-node-workspaces-plugin
branch
from
270b875
to
f7eb8a0
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/release-please.yml (1 hunks)
- release-please-config.json (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- .github/workflows/release-please.yml
- release-please-config.json
.github/workflows/release-please.yml
Outdated
| target-branch: dev | ||
| default-branch: dev | ||
|
|
||
| # TODO: get this back when release-please-action@4 gets an update for pnpm node workspaces. |
There was a problem hiding this comment.
Is there a task we can link in the commit message? Or else add here so we don't forget about this in a sea of TODOs
There was a problem hiding this comment.
Good point, done!
later, upgrade to v4(#133)
edgarkhanzadian
force-pushed
the
ci/release-please-use-node-workspaces-plugin
branch
from
f7eb8a0
to
0d09311
Compare
Currently, release-please doesn't bump version of a local package when the dependency of that local package got updated. E.g. when models package is updated and released, we need to also bump and release query package.
Using plugin
node-workspaceson release-please should technically fix that. However, there is a regression on release-please-action@4 package as it seems like on release it swapsworkspace:protocol with a specific package version(seems like on v3 it worked fine). There is a fix for it in this PR: googleapis/release-please#2281 . So opening this PR as draft until release-please-action gets updated.Summary by CodeRabbit
release-please-actionfromv4to `v3 and updated configuration parameters.release-please-config.json.