Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update protobuf dependencies to v3.23.1 and gprc to 1.55.1 #1698

Merged
merged 4 commits into from
May 23, 2023
Merged

deps: update protobuf dependencies to v3.23.1 and gprc to 1.55.1 #1698

merged 4 commits into from
May 23, 2023

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented May 23, 2023 •
edited
Loading

TODO: Close #1369 after this PR is merged.

@mpeddada1 mpeddada1 requested a review from a team as a code owner May 23, 2023 14:28
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 23, 2023
@suztomo
Copy link
Member

suztomo commented May 23, 2023

You may have to update the C++ option. https://github.com/googleapis/sdk-platform-java/pull/1369/files#r1164950006

@mpeddada1 mpeddada1 mentioned this pull request May 23, 2023
Closed
1 task
@suztomo
Copy link
Member

suztomo commented May 23, 2023

ci / showcase is failing.

  bazel-bin/showcase/verify_proto
(14:45:41) INFO: Elapsed time: 341.420s, Critical Path: 31.43s
(14:45:41) INFO: 625 processes: 219 internal, 388 linux-sandbox, 18 worker.
(14:45:41) INFO: Build completed successfully, 625 total actions
(14:45:41) INFO: Running command line: bazel-bin/showcase/verify_proto proto
diff -ru /home/runner/work/sdk-platform-java/sdk-platform-java/showcase/proto-gapic-showcase-v1beta1/src/main/java/com/google/showcase/v1beta1/AttemptSequenceRequest.java /home/runner/.cache/bazel/_bazel_runner/cf5fb8c2c66b8a944ea6af7c9b248db5/execroot/gapic_generator_java/bazel-out/k8-fastbuild/bin/showcase/verify_proto.runfiles/gapic_generator_java/proto_unpacked/proto-google-cloud-showcase-v1beta1-java/src/main/java/com/google/showcase/v1beta1/AttemptSequenceRequest.java
--- /home/runner/work/sdk-platform-java/sdk-platform-java/showcase/proto-gapic-showcase-v1beta1/src/main/java/com/google/showcase/v1beta1/AttemptSequenceRequest.java	2023-05-23 14:38:00.460649223 +0000
+++ /home/runner/.cache/bazel/_bazel_runner/cf5fb8c2c66b8a944ea6af7c9b248db5/execroot/gapic_generator_java/bazel-out/k8-fastbuild/bin/showcase/verify_proto.runfiles/gapic_generator_java/proto_unpacked/proto-google-cloud-showcase-v1beta1-java/src/main/java/com/google/showcase/v1beta1/AttemptSequenceRequest.java	1980-01-01 00:00:00.000000000 +0000
@@ -26,11 +26,6 @@
     return new AttemptSequenceRequest();
   }
 
-  @java.lang.Override
-  public final com.google.protobuf.UnknownFieldSet
-  getUnknownFields() {
-    return this.unknownFields;
-  }
   public static final com.google.protobuf.Descriptors.Descriptor
       getDescriptor() {
     return com.google.showcase.v1beta1.SequenceOuterClass.internal_static_google_showcase_v1beta1_AttemptSequenceRequest_descriptor;
@@ -191,11 +186,13 @@
     return com.google.protobuf.GeneratedMessageV3
         .parseWithIOException(PARSER, input, extensionRegistry);
   }
+
   public static com.google.showcase.v1beta1.AttemptSequenceRequest parseDelimitedFrom(java.io.InputStream input)
       throws java.io.IOException {
     return com.google.protobuf.GeneratedMessageV3
         .parseDelimitedWithIOException(PARSER, input);
   }

=> https://github.com/googleapis/sdk-platform-java/tree/main/showcase#update-the-golden-showcase-files

@mpeddada1 Can you update the golden file?

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels May 23, 2023
@mpeddada1 mpeddada1 requested review from burkedavison and suztomo May 23, 2023 15:19
burkedavison
burkedavison reviewed May 23, 2023
View reviewed changes
gax-java/dependencies.properties Outdated
@@ -23,7 +23,7 @@ version.gax_httpjson=0.112.1-SNAPSHOT
# Versions for dependencies which actual artifacts differ between Bazel and Gradle.
# Gradle build depends on prebuilt maven artifacts, while Bazel build depends on Bazel workspaces
# with the sources.
version.com_google_protobuf=3.21.12
version.com_google_protobuf=3.23.1
version.google_java_format=1.15.0
version.io_grpc=1.54.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version should be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Done.

@mpeddada1 mpeddada1 changed the title deps: update protobuf dependencies to v3.23.1 deps: update protobuf dependencies to v3.23.1 and gprc to 1.55.1 May 23, 2023
@mpeddada1 mpeddada1 requested a review from burkedavison May 23, 2023 15:38
@sonarqubecloud
Copy link

[gapic-generator-java-root] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

0.0% 0.0% Coverage
0.3% 0.3% Duplication

@sonarqubecloud
Copy link

[java_showcase_integration_tests] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

0.0% 0.0% Coverage
0.3% 0.3% Duplication

@sonarqubecloud
Copy link

[java_showcase_unit_tests] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

0.0% 0.0% Coverage
0.3% 0.3% Duplication

@suztomo
Copy link
Member

suztomo commented May 23, 2023

Sonar is complaining https://github.com/googleapis/sdk-platform-java/pull/1698/checks?check_run_id=13697463444

0.0% Coverage on New Code (is less than 80%)

But we're not adding new code. It's fine.

@mpeddada1 mpeddada1 mentioned this pull request May 23, 2023
Merged
1 task
@mpeddada1 mpeddada1 merged commit 1f56175 into main May 23, 2023
@mpeddada1 mpeddada1 deleted the protobuf23.1 branch May 23, 2023 17:39
@release-please release-please bot mentioned this pull request May 23, 2023
Merged
@mpeddada1 mpeddada1 mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison approved these changes

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpeddada1 @suztomo @burkedavison