Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otel's Method Name is different between gRPC and HttpJson #2502

Open
lqiu96 opened this issue Feb 26, 2024 · 0 comments · May be fixed by #2543
Open

Otel's Method Name is different between gRPC and HttpJson #2502

lqiu96 opened this issue Feb 26, 2024 · 0 comments · May be fixed by #2543
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lqiu96
Copy link
Contributor

lqiu96 commented Feb 26, 2024

Discovered in the Otel Draft PR: #2500

The Method Name is different between the two transports:
gRPC: Echo.Echo
HttpJson: google.showcase.v1beta1.Echo/Echo.

I believe this is because of the different Regex Matchers used to extract the MethodName:
gRPC:

private static final Pattern FULL_METHOD_NAME_REGEX = Pattern.compile("^.*?([^./]+)/([^./]+)$");

HttpJson:
private static final Pattern FULL_METHOD_NAME_REGEX = Pattern.compile("^(.+)\\.(.+)$");

We should be consistent and pick one way to display the method name.

@lqiu96 lqiu96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 26, 2024
@lqiu96 lqiu96 changed the title Otel's Method Name is different between gRPC and HttpJSon Otel's Method Name is different between gRPC and HttpJson Feb 26, 2024
blakeli0 added a commit that referenced this issue Mar 14, 2024
Builds off #2433,
based on the design in go/java-gapic-otel-metrics-design.

Discovered two issues via showcase tests:
1. #2502
2. #2503

These issues are not blocking for this PR.

---------

Co-authored-by: Blake Li <blakeli@google.com>
@blakeli0 blakeli0 added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants