Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use ServiceName + MethodName as the regex for Otel #2543

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Use ServiceName + MethodName as the regex for Otel #2543

wants to merge 3 commits into from

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Mar 7, 2024

Fixes: #2502

Use a consistent Regex matching pattern for both gRPC and HttpJson. Copy the pattern used for gRPC into HttpJson.

Looking at the Method Descriptor for HttpJson (Compute as an example), the full method name does not match service.resource.action: https://github.com/googleapis/google-cloud-java/blob/1f9e63224424327a08e3663985773546b3f7808b/java-compute/google-cloud-compute/src/main/java/com/google/cloud/compute/v1/stub/HttpJsonBackendServicesStub.java#L85

It seems to match ServiceName/MethodName.

@lqiu96 lqiu96 requested a review from a team as a code owner March 7, 2024 18:25
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 7, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 7, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Failed Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Failed Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Otel's Method Name is different between gRPC and HttpJson
2 participants
@lqiu96 @alicejli