Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update root pom.xml template to use maven deploy v3.1.3 #3211

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Sep 17, 2024

Issue discovered in https://github.com/googleapis/google-cloud-java/actions/runs/10908789692/job/30275696533?pr=11081

       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-deploy-plugin</artifactId>
-        <version>3.1.3</version>
+        <version>3.1.2</version>
         <configuration>
           <skip>true</skip>
         </configuration>

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 17, 2024
Copy link

sonarcloud bot commented Sep 17, 2024

Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lqiu96 lqiu96 changed the title chore: Update root pom.xml tempalte to deploy v3.1.3 chore: Update root pom.xml template to use maven deploy v3.1.3 Sep 17, 2024
@lqiu96
Copy link
Contributor Author

lqiu96 commented Sep 18, 2024

Error:

======================================================================
FAIL: test_entry_point_running_in_container (library_generation.test.integration_tests.IntegrationTest.test_entry_point_running_in_container)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/sdk-platform-java/sdk-platform-java/library_generation/test/integration_tests.py", line 172, in test_entry_point_running_in_container
    self.assertFalse(
AssertionError: True is not false

----------------------------------------------------------------------
Ran 1 test in 508.928s

FAILED (failures=1)

@blakeli0
Copy link
Collaborator

Error:

======================================================================
FAIL: test_entry_point_running_in_container (library_generation.test.integration_tests.IntegrationTest.test_entry_point_running_in_container)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/sdk-platform-java/sdk-platform-java/library_generation/test/integration_tests.py", line 172, in test_entry_point_running_in_container
    self.assertFalse(
AssertionError: True is not false

----------------------------------------------------------------------
Ran 1 test in 508.928s

FAILED (failures=1)

You may have to update the golden files for hermetic build integration tests too, which is a branch of google-cloud-java. cc: @JoeWang1127 @diegomarquezp

@lqiu96
Copy link
Contributor Author

lqiu96 commented Sep 18, 2024

Error:

======================================================================
FAIL: test_entry_point_running_in_container (library_generation.test.integration_tests.IntegrationTest.test_entry_point_running_in_container)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/sdk-platform-java/sdk-platform-java/library_generation/test/integration_tests.py", line 172, in test_entry_point_running_in_container
    self.assertFalse(
AssertionError: True is not false

----------------------------------------------------------------------
Ran 1 test in 508.928s

FAILED (failures=1)

You may have to update the golden files for hermetic build integration tests too, which is a branch of google-cloud-java. cc: @JoeWang1127 @diegomarquezp

Thanks updated the branch in google-cloud-java and the jobs passes now. Merging this in.

@lqiu96 lqiu96 merged commit 8bdaa2e into main Sep 18, 2024
34 checks passed
@lqiu96 lqiu96 deleted the update-rootpom-template branch September 18, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants