Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove cvss.proto in containeranalysis from being excluded. #3213

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

blakeli0
Copy link
Collaborator

@blakeli0 blakeli0 commented Sep 18, 2024

The protoc generated files for cvss.proto are outdated for containeranalysis, we are going to update them in googleapis/google-cloud-java#11155. This cvss.proto was exclude before because the whole v1beta1 version was not configured to be updated.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 18, 2024
@diegomarquezp
Copy link
Contributor

only in /home/runner/work/sdk-platform-java/sdk-platform-java/library_generation/test/resources/integration/golden/pom.xml
//project/build/plugins/plugin/version=3.1.3: 1
only in /home/runner/work/sdk-platform-java/sdk-platform-java/output/google-cloud-java/pom.xml
Generation finished successfully. Will now compare differences between generated and existing libraries
**************************************************
Checking for differences in 'java-apigee-connect'.
//project/build/plugins/plugin/version=3.1.2: 1

This doesn't look like it would be affected by this change. I retried it manually just in case.

@diegomarquezp
Copy link
Contributor

Correction. The PR needs to be updated to the latest of main given the golden changes in #3211

Copy link

sonarcloud bot commented Sep 18, 2024

Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@blakeli0 blakeli0 merged commit 089c291 into main Sep 19, 2024
34 of 35 checks passed
@blakeli0 blakeli0 deleted the add-cvss branch September 19, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants