Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show stdout for docker pull #121

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Show stdout for docker pull #121

merged 2 commits into from
Nov 8, 2018

Conversation

busunkim96
Copy link
Contributor

Closes #118.

I wasn't sure whether to show stdout for only docker pull or every time the run function is called.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2018
@theacodes
Copy link
Contributor

I wasn't sure whether to show stdout for only docker pull or every time the run function is called.

only for docker pull is fine for now.

tseaver
tseaver reviewed Nov 8, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busunkim96 busunkim96 merged commit 84cce4e into googleapis:master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@theacodes theacodes theacodes approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busunkim96 @theacodes @tseaver @googlebot