Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show stdout for docker pull #121

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Show stdout for docker pull #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
411b34f
Show stdout for docker pull
busunkim96 Nov 8, 2018
f5481a3
Merge branch 'master' into show-docker-output
busunkim96 Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion synthtool/gcp/artman.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,6 @@ def _ensure_dependencies_installed(self):

def _install_artman(self):
log.debug("Pulling artman image.")
shell.run(["docker", "pull", f"googleapis/artman:{ARTMAN_VERSION}"])
shell.run(
["docker", "pull", f"googleapis/artman:{ARTMAN_VERSION}"], hide_output=False
)
9 changes: 7 additions & 2 deletions synthtool/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,16 @@
from synthtool import log


def run(args, *, cwd=None, check=True):
def run(args, *, cwd=None, check=True, hide_output=True):
if hide_output:
stdout = subprocess.PIPE
else:
stdout = None

try:
return subprocess.run(
args,
stdout=subprocess.PIPE,
stdout=stdout,
stderr=subprocess.STDOUT,
cwd=cwd,
check=check,
Expand Down