Skip to content

Commit

Permalink
Webhooks: Move "running" logging to Debug (#1249)
Browse files Browse the repository at this point in the history
Also took the liberty of removing the Info logging of the GameServer
webhook entire patch logging, since it was likely leftover from
issue debugging.

Co-authored-by: Robert Bailey <robertbailey@google.com>
  • Loading branch information
markmandel and roberthbailey committed Jan 6, 2020
1 parent 2ec5139 commit 9e18242
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions pkg/gameservers/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,6 @@ func (c *Controller) creationMutationHandler(review admv1beta1.AdmissionReview)
return review, errors.Wrapf(err, "error creating json for patch for GameServer %s", gs.ObjectMeta.Name)
}

c.loggerForGameServer(gs).WithField("patch", string(json)).Infof("patch created!")

pt := admv1beta1.PatchTypeJSONPatch
review.Response.PatchType = &pt
review.Response.Patch = json
Expand Down
2 changes: 1 addition & 1 deletion pkg/util/webhooks/webhooks.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func (wh *WebHook) AddHandler(path string, gk schema.GroupKind, op v1beta1.Opera

// handle Handles http requests for webhooks
func (wh *WebHook) handle(path string, w http.ResponseWriter, r *http.Request) error { // nolint: interfacer
wh.logger.WithField("path", path).Info("running webhook")
wh.logger.WithField("path", path).Debug("running webhook")

var review v1beta1.AdmissionReview
err := json.NewDecoder(r.Body).Decode(&review)
Expand Down

0 comments on commit 9e18242

Please sign in to comment.