Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks: Move "running" logging to Debug #1249

Merged
merged 2 commits into from
Jan 6, 2020

Conversation

markmandel
Copy link
Member

Also took the liberty of removing the Info logging of the GameServer webhook entire patch logging, since it was likely leftover from issue debugging.

Also took the liberty of removing the Info logging of the GameServer
webhook entire patch logging, since it was likely leftover from
issue debugging.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/operations Installation, updating, metrics etc labels Dec 30, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4a5241ac-7da3-40af-b32f-e341fd2c2c7d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1249/head:pr_1249 && git checkout pr_1249
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-635079f

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ea4e1f08-64b3-4aee-a3a9-fbb3a5c64555

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1249/head:pr_1249 && git checkout pr_1249
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-6f53598

@roberthbailey roberthbailey merged commit 9e18242 into googleforgames:master Jan 6, 2020
@markmandel markmandel deleted the logging/webhooks branch January 6, 2020 18:34
@markmandel markmandel added this to the 1.3.0 milestone Jan 10, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Also took the liberty of removing the Info logging of the GameServer
webhook entire patch logging, since it was likely leftover from
issue debugging.

Co-authored-by: Robert Bailey <robertbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants