Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and remove the udp-server and tcp-server images #1890

Closed
roberthbailey opened this issue Nov 5, 2020 · 2 comments · Fixed by #1992
Closed

Deprecate and remove the udp-server and tcp-server images #1890

roberthbailey opened this issue Nov 5, 2020 · 2 comments · Fixed by #1992
Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc
Milestone
1.13.0

Comments

@roberthbailey
Copy link
Member

Since #1771 merged we are now releasing three dummy golang game server images with every release. e.g. for the 1.9.0 release we included:

  • simple-game-server:0.1
  • tcp-server:0.4
  • udp-server:0.21

These all share essentially the same code, and the simple-game-server is a combination of the other two. We should work to deprecate the tcp-server and udp-server images and stop releasing them.

At a minimum, we need to:

  • Announce that the images will stop being maintained and released
  • Update our documentation to reference the simple-game-server image
  • Update our test code to use the simple-game-server image
  • Update the release checklist to stop building the udp and tcp images
  • Remove the code and dockerfiles for the udp and tcp images
@roberthbailey roberthbailey added the kind/feature New features for Agones label Nov 5, 2020
@markmandel markmandel mentioned this issue Nov 17, 2020
Closed
10 tasks
@roberthbailey
Copy link
Member Author

We discussed this during the monthly community meeting today. Deprecating the tcp-server would be a good start since it is used less widely than the udp-server.

@markmandel
Copy link
Member

To note in #1894 we have the ability to create windows images for both simple-tcp and simple-udp - we will need to port that over to the simple-game-server implementation when we do this work (although it doesn't seem complicated)

@markmandel markmandel added area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc and removed kind/feature New features for Agones labels Feb 11, 2021
markmandel added a commit to markmandel/agones that referenced this issue Feb 11, 2021
@markmandel
Remove simple-tcp and simple-udp
104c86d 
This covers:
* Moving the windows build scripts from simple-udp to simple-game-server
* Moving all the documentation to use simple-game-server (tested this by
 hand)
* Updated all the examples to use simple-game-servers
* Removal of both simple-udp and simple-tcp

Closes googleforgames#1890
@markmandel markmandel mentioned this issue Feb 11, 2021
Merged
markmandel added a commit that referenced this issue Feb 12, 2021
@markmandel
Remove simple-tcp and simple-udp (#1992)
c833e5d 
* Remove simple-tcp and simple-udp

This covers:
* Moving the windows build scripts from simple-udp to simple-game-server
* Moving all the documentation to use simple-game-server (tested this by
 hand)
* Updated all the examples to use simple-game-servers
* Removal of both simple-udp and simple-tcp

Closes #1890

* Review updates:

* Only remove example links on release (had to add `‌` because of strange markdown formatting issues)
* Update fleet_autoscaling.py fleet name
@markmandel markmandel added this to the 1.13.0 milestone Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

Remove simple-tcp and simple-udp markmandel/agones
2 participants
@markmandel @roberthbailey